Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach upsdrvctl to list device config names and show run-time status, and to optionally hide the start-up banner #2568

Merged
merged 39 commits into from
Jul 31, 2024

Conversation

jimklimov
Copy link
Member

@jimklimov jimklimov commented Jul 30, 2024

…g logs [networkupstools#2567]

...and avoid a potential argv array overflow (or at least useless NULL reporting) along the way

Signed-off-by: Jim Klimov <[email protected]>
@jimklimov jimklimov added enhancement documentation service/daemon start/stop General subject for starting and stopping NUT daemons (drivers, server, monitor); also BG/FG/Debug NUT protocols labels Jul 30, 2024
@jimklimov jimklimov added this to the 2.8.3 milestone Jul 30, 2024
…tps://www.networkupstools.org/" if PACKAGE_URL points completely elsewhere) [networkupstools#1949]

Tested with "VER" command

Signed-off-by: Jim Klimov <[email protected]>
…ed "https://www.networkupstools.org/" if PACKAGE_URL points completely elsewhere) [networkupstools#1949]

Tested with "GET VAR dummy server.info" command

Signed-off-by: Jim Klimov <[email protected]>
…fully (and abort if there is no common BASE) [networkupstools#1949]

Signed-off-by: Jim Klimov <[email protected]>
@jimklimov jimklimov changed the title Teach upsdrvctl to list device config names, and to optionally hide the start-up banner Teach upsdrvctl to list device config names and show run-time status, and to optionally hide the start-up banner Jul 31, 2024
@AppVeyorBot

This comment was marked as resolved.

@AppVeyorBot
Copy link

@jimklimov
Copy link
Member Author

Example screenshot currently:

:; upsdrvctl status
Network UPS Tools - UPS driver controller 2.8.2.705.100-805-g68344de5b
Can't open /var/state/ups/dummy-ups-dummy: No such file or directory
dummy   dummy-ups       N/A     -3      NOT_RESPONSIVE  N/A
eco650  usbhid-ups      RUNNING 3559207 RESPONSIVE      3559207 "OL"

…psdrvquery_debug_level hushing around upsdrvquery_connect_drvname_upsname() attempt [networkupstools#2567]

Signed-off-by: Jim Klimov <[email protected]>
@jimklimov
Copy link
Member Author

UPDATED screenshot:

:; NUT_QUIET_INIT_BANNER=true ./drivers/upsdrvctl status
UPSNAME UPSDRV  PF_RUNNING      PF_PID  S_RESPONSIVE    S_PID   S_STATUS
dummy   dummy-ups       N/A     -3      NOT_RESPONSIVE  N/A
eco650  usbhid-ups      RUNNING 3559207 RESPONSIVE      3559207 "OL"

…_GIT_TRUNK if not provided explicitly [networkupstools#1949]

Signed-off-by: Jim Klimov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement NUT protocols service/daemon start/stop General subject for starting and stopping NUT daemons (drivers, server, monitor); also BG/FG/Debug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upsdrvctl would benefit from CLI options to list known devices, and their current health
2 participants